Minor gas optimizations #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moodlezoup
commented
Aug 17, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
It's annoying that we end up with mulDivDown in solidity and mulDivUp in yul 😄 |
Signed-off-by: Merlin Egalite <[email protected]>
MathisGD
requested review from
a team,
Rubilmax,
MerlinEgalite,
pakim249CAL,
Jean-Grimal,
makcandrov,
QGarchery,
peyha and
MathisGD
and removed request for
a team
MerlinEgalite
previously approved these changes
Aug 18, 2023
|
I switched mulDivUp to full solidity too, because it reduces the gas cost on average with our yarn tests |
MathisGD
previously approved these changes
Aug 18, 2023
Jean-Grimal
previously approved these changes
Aug 18, 2023
MerlinEgalite
dismissed stale reviews from Jean-Grimal, MathisGD, and themself
via
7b21dd0
MathisGD
approved these changes
Aug 18, 2023
MerlinEgalite
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.